Skip to content

Expose templates of LLM grader instances and default templates of LLM grader classes.#124

Merged
weizhang25 merged 4 commits intoagentscope-ai:mainfrom
weizhang25:expose-templates-and-default-templates-of-llm-graders
Feb 26, 2026
Merged

Expose templates of LLM grader instances and default templates of LLM grader classes.#124
weizhang25 merged 4 commits intoagentscope-ai:mainfrom
weizhang25:expose-templates-and-default-templates-of-llm-graders

Conversation

@weizhang25
Copy link
Copy Markdown
Collaborator

@weizhang25 weizhang25 commented Feb 12, 2026

  1. Define get_template instance method in LLMGrader to expose the template of LLM grader instances.
  2. Define get_default_template class method in LLMGrader to expose the default templates of LLM grader classes.
  3. Updated UTs.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 12, 2026

Summary of Changes

Hello @weizhang25, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the LLMGrader system by providing explicit methods to access both instance-specific and class-level default prompt templates. This change improves the introspection capabilities of the grading framework, allowing developers to easily inspect and understand the prompts used by different LLM graders, and establishes a clearer pattern for defining default templates in subclasses.

Highlights

  • Template Exposure: Introduced get_template instance method to retrieve the current prompt template of an LLMGrader instance.
  • Default Template Access: Added get_default_template class method to access the default prompt template for LLMGrader classes.
  • Template Consistency: Updated ActionAlignmentGrader to use a DEFAULT_TEMPLATE class variable for consistent default template definition.
  • Unit Test Enhancements: Enhanced unit tests to cover the new template exposure methods and enforce template validation during initialization.
Changelog
  • openjudge/graders/agent/action/action_alignment.py
    • Defined DEFAULT_TEMPLATE as a class attribute.
    • Updated the __init__ method to reference DEFAULT_TEMPLATE for the default prompt.
    • Modified the super().__init__ call to use self.DEFAULT_TEMPLATE when no template is provided.
  • openjudge/graders/llm_grader.py
    • Added a DEFAULT_TEMPLATE class attribute as a placeholder, with a comment instructing subclasses to override it.
    • Introduced a ValueError check in __init__ to ensure a template is always provided.
    • Implemented get_template instance method to return the grader's current template.
    • Implemented get_default_template class method to return the class's default template.
  • tests/graders/agent/action/test_action_alignment.py
    • Added assertions to test_initialization to verify get_template and get_default_template functionality and content.
    • Adjusted the pytestmark decorator application for quality tests.
  • tests/graders/test_llm_grader.py
    • Imported LanguageEnum.
    • Added a new test case test_initialization_failure_with_invalid_template_type to check for ValueError when an invalid template type is passed.
    • Extended test_initialization_with_model_dict to include assertions for get_template and get_default_template.
    • Adjusted the pytestmark decorator application for quality tests.
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a way to expose templates from LLMGrader instances and classes. It adds a DEFAULT_TEMPLATE class attribute to LLMGrader and its subclasses, and two new methods: get_template() for instance-specific templates and get_default_template() for class-level default templates. The changes are well-implemented and include corresponding updates to unit tests. My main feedback is to consider enforcing that subclasses of LLMGrader override the DEFAULT_TEMPLATE attribute to prevent potential runtime issues.

weidankong
weidankong reviewed Feb 20, 2026
View reviewed changes
weidankong
weidankong reviewed Feb 20, 2026
View reviewed changes
ployts
ployts approved these changes Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ployts ployts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK. Are the other graders going to be updated later based on the current design?

@weizhang25
Copy link
Copy Markdown
Collaborator Author

weizhang25 commented Feb 26, 2026

The changes look OK. Are the other graders going to be updated later based on the current design?

Will have a follow-up PR to fix all other graders.

@weizhang25 weizhang25 merged commit fa8af37 into agentscope-ai:main Feb 26, 2026
1 check passed
@weizhang25 weizhang25 deleted the expose-templates-and-default-templates-of-llm-graders branch February 26, 2026 20:04
weizhang25 added a commit to weizhang25/OpenJudge that referenced this pull request Feb 26, 2026
@weizhang25
Expose templates of LLM grader instances and default templates of LLM…
d36d6bd 
… grader classes. (agentscope-ai#124)

* Expose templates of grader instances and default templates of grader classes.

* Resolve code review feedbacks.

* Update function argument type annotation.
@weizhang25 weizhang25 mentioned this pull request Feb 26, 2026
Merged
XiaoBoAI pushed a commit that referenced this pull request Mar 4, 2026
@weizhang25
Set default templates in all subclasses of LLMGrader. (#131)
2dd29ce 
* Expose templates of LLM grader instances and default templates of LLM grader classes. (#124)

* Expose templates of grader instances and default templates of grader classes.

* Resolve code review feedbacks.

* Update function argument type annotation.

* fix 1

* Set default templates in all subclasses of LLMGrader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weidankong weidankong weidankong approved these changes

@ployts ployts ployts approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weizhang25 @weidankong @ployts